Repository navigation
ref(router): Adopt V8 import paths while retaining V6 - #126570
Merged
Merged
Conversation
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-1twxiy7gw.sentry.dev |
Contributor
Author
|
bugbot run |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2d43323. Configure here.
natemoo-re
approved these changes
Oct 6, 2026
| * `Router` instance. | ||
| */ | ||
| export function createReactRouter3Navigate(router: Router): ReactRouter3Navigate { | ||
| export function createReactRouter3Navigate(router: DataRouter): ReactRouter3Navigate { |
Member
There was a problem hiding this comment.
how many layers deep can we go? 😅
Contributor
Author
There was a problem hiding this comment.
we'll keep going till morale improves 😭
nsdeschenes
requested review from
Lms24,
chargome,
msonnb and
nicohrubec
and removed request for
a team
October 7, 2026 10:22
Point the direct dependency at the patched snapshot introduced on master so frozen installs resolve it after the merge.
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move first-party React Router imports and test mocks to V8 package paths while continuing to run and typecheck React Router 6.30.6. This is the preparatory import migration slice of #126218.
react-routerandreact-router/domresolve through small V6 compatibility modules. Rsbuild's Rspack rules and both Jest configurations apply the mappings to first-party code, preserving dependency resolution and shared router contexts. TypeScript uses V6 declarations, including aliases for the renamed internal router exports. Nuqs adapters and Sentry tracing integrations continue to use V6.The three commits separate:
require, and Jest module references. Only the compatibility implementations are exempt.